Skip to content

Update DistTasks.yml #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Update DistTasks.yml #168

merged 1 commit into from
Sep 21, 2021

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Sep 20, 2021

During my investigations I discovered this typo which was causing a problem:

mkdir: cannot create directory ‘serial-monitor_linux_arm_6’: File exists
task: Failed to run task "dist:all": task: Failed to run task "dist:Linux_ARM64": exit status 1

During my investigations I discovered this typo which was causing a problem:
```
mkdir: cannot create directory ‘serial-monitor_linux_arm_6’: File exists
task: Failed to run task "dist:all": task: Failed to run task "dist:Linux_ARM64": exit status 1
```
@umbynos umbynos requested a review from per1234 September 20, 2021 15:42
@umbynos umbynos self-assigned this Sep 20, 2021
@umbynos umbynos merged commit 5004e71 into main Sep 21, 2021
@umbynos umbynos deleted the umbynos-patch-1 branch September 21, 2021 09:11
@per1234
Copy link
Contributor

per1234 commented Sep 21, 2021

Thanks @umbynos! I see this typo has propagated to every project we used the taskfile in. However, I believe it is innocuous in the other projects since the go build command will just overwrite the existing contents of the {{.PROJECT_NAME}}_linux_arm_6 folder when the second task runs.

If so, we don't need to worry about there being problems with the artifacts produced by the releases that used the previous version of the taskfile in those projects. Am I right about that?

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Sep 21, 2021
@umbynos
Copy link
Contributor Author

umbynos commented Sep 21, 2021

That's correct. I stumbled upon this problem because I tried to create the dir this way before running the go build command (to avoid permission issues). But without the folder creation, everything works smoothly (that's why we never discovered the typo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants